Split conformance classes into multiple api modules#1556
Split conformance classes into multiple api modules#1556francbartoli wants to merge 3 commits intogeopython:masterfrom
Conversation
613d20b to
46be41e
Compare
1f6650b to
83ec34d
Compare
2bbb0f8 to
6a3f43f
Compare
doublebyte1
left a comment
There was a problem hiding this comment.
@francbartoli +1 for simplifying api.py . Could you just address the conflicts in that file?
|
This change has been integrated in the PR #1405 , e.g. here: I think everyone agrees that this change makes sense. To get it to main with the the least amount of conflicts, it might make sense though to close this PR and use the version which is part of the large diff of #1405 |
|
+1. This is implemented as part of the api.py refactor in #1405 that will be issued for review/approval shortly. |
|
Thanks for the feedbacks @doublebyte1 @totycro @tomkralidis. I see the overlap with #1405, however I believe this has the intent to represent conformance classes in a more object oriented way rather than simply dicts. This could be useful to make them loaded and offered dynamically based on the actual configuration and the parts really implemented by the overall specs. Maybe it's better to open another PR after the merge of #1405 |
|
@francbartoli thanks, +1/agree to build up conformance based on config after #1405 |
Overview
This PR organizes the conformance classes into different modules, one for each supported OGC API and use a generic
dataclassto define the instance of each conformance class. It uses a temporary namespaceapi_to do not collide with the existingapi.pymodule while we are discussing the transition.Related issue / discussion
It's been designed with the same intent of #1405 so it can be compatible with that approach
Additional information
Dependency policy (RFC2)
Updates to public demo
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)