add path: to /collection_id for /map#2294
Merged
tomkralidis merged 1 commit intogeopython:masterfrom Mar 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Most flask endpoints in pygeoapi use
<path:collection_id>to allow for nested collection names likemy_map/elevationvsmy_map/land_use.For instance
@BLUEPRINT.route('/collections/<path:collection_id>/position')However for
/mapthis didn't appear to be presentAs such, if you change the default WMS provider to have a
/then it will break, for instance like this.However, if I add the
pathfix then it will load fine and allow collection names with/I have changed this to add the
pathsince I presume this was missing unless I am missing something about the internal workings of the WMS provider.Related Issue / discussion
Discussed offline with @webb-ben
Additional information
Dependency policy (RFC2)
Updates to public demo
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)