Skip to content

Conversation

@gschwind
Copy link
Collaborator

@gschwind gschwind commented Jul 13, 2018

Hello,

Because XML is 'text/*' we should set the charset in content type header
this the purpose of this changes.

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
  • I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

Because XML is 'text/*' we should set the charset in content type header
this the pupose of this changes.
@gschwind
Copy link
Collaborator Author

To pass unit test this patch series need #361

Best regards

@cehbrecht cehbrecht added this to the 4.2.0 milestone Jul 16, 2018
@cehbrecht cehbrecht added the bug label Jul 16, 2018
@cehbrecht cehbrecht self-requested a review July 16, 2018 09:10
Copy link
Collaborator

@cehbrecht cehbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@cehbrecht
Copy link
Collaborator

This PR removes get_headers method ... but it was not used anywhere.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 73.094% when pulling 947c0f4 on gschwind:fix-001 into c9d46d6 on geopython:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 73.094% when pulling 947c0f4 on gschwind:fix-001 into c9d46d6 on geopython:master.

@cehbrecht cehbrecht merged commit 207f7e9 into geopython:master Jul 16, 2018
@cehbrecht
Copy link
Collaborator

@gschwind: looks simple enough ... so I merge it. Thanks :)

@gschwind
Copy link
Collaborator Author

Hello,

The get_headers function was used because it overrides HTTPException.get_headers

Best regards

@gschwind gschwind deleted the fix-001 branch July 25, 2018 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants