[FEATURE] Extend connection options for clients #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgringer
approved these changes
Sep 11, 2019
georgringer
requested changes
Sep 11, 2019
josefglatz
force-pushed
the
featur/guzzle
branch
from
8d5fc42 to
a10286d
Compare
This patch extends the client with three properties: - host_header: add an optional "Host: yourdomain.com" header - ignore_cert_errors: force ignoring certificate errors - force_ip_resolve: force IPv4/-6 resolving of the client In order to make this possible, the TYPO3 core wrapper RequestFactory::class for guzzle is used instead of GeneralUtility::getUrl(). In addition, the following bugs are fixed: - empty update_comment field on client update - handle missing disk_total_space (fallback to 0) - handle missing disk_free_space (fallback to 0) - handle extensions with not allowed "state" values (fallback to 999 => n/a) - handle extensions without dependencies Fixes: georgringer#159 Fixes: georgringer#160 Fixes: georgringer#161 Fixes: georgringer#162 Fixes: georgringer#163
josefglatz
force-pushed
the
featur/guzzle
branch
from
a10286d to
470b69a
Compare
Collaborator
Author
|
@georgringer jfyi: I test this patch now in production 🤟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch extends the client with three properties:
In order to make this possible, the TYPO3 core wrapper
RequestFactory::class for guzzle is used instead of
GeneralUtility::getUrl().
In addition, the following bugs are fixed:
Fixes: #159
Fixes: #160
Fixes: #161
Fixes: #162
Fixes: #163