Skip to content

Conversation

@liayn
Copy link
Collaborator

@liayn liayn commented Nov 21, 2025

No description provided.

@liayn liayn marked this pull request as draft November 21, 2025 07:42
@maslme
Copy link

maslme commented Nov 21, 2025

I've tested your Pull request in my TYPO3 12.4.39, composer installation and it crashed my whole installation with:

PHP Fatal error: Type of T3Monitor\T3monitoring\Domain\TypeConverter\ClientFilterDemandConverter::$sourceTypes must not be defined (as in class TYPO3\CMS\Extbase\Property\TypeConverter\AbstractTypConverter) in [...]/Classes/Domain/TypeConverter/ClientFilterDemandConverter.php on line 21

Fatal error: Type of T3Monitor\T3monitoring\Domain\TypeConverter\ClientFilterDemandConverter::$sourceTypes must not be defined (as in class TYPOe\CMS\Extbase\Property\TypeConverter\AbstractTypeConverter) in [...]/Classes/Domain/TypeConverter/ClientFilterDemandConverter.php on line 21

@liayn
Copy link
Collaborator Author

liayn commented Nov 21, 2025

It's a draft and work in progress

@liayn liayn mentioned this pull request Nov 21, 2025
@liayn liayn marked this pull request as ready for review November 21, 2025 14:26
@liayn
Copy link
Collaborator Author

liayn commented Nov 22, 2025

@maslme I'd be happy, if you could test this again with your v12 installation.

@liayn liayn self-assigned this Nov 22, 2025
@christian-fries
Copy link

@liayn There seems to be an issue in TYPO3 12. The client list is empty. Using XDebug in the StatisticController proves that the clients are loaded from database. But doing <f:debug>{_all}</f:debug> in the section named Content in Statistic/Index.html does not list any of the variables assigned in the controller.
Bildschirmfoto 2025-11-24 um 13 40 30
Does not sound like a configuration issue to me...

@liayn
Copy link
Collaborator Author

liayn commented Nov 24, 2025

@christian-fries Thanks for the test. I know the issue, it's the view being renamed to moduleTemplate due to type incompatibility of the moduleTemplate with viewinterface in Extbase. Will fix

@christian-fries
Copy link

The mentioned problem is solved with the latest changes.

I did some spot checks in TYPO3 12, the PR seems to be fine

  • Import data of a single client ✅
  • Import core and extensions in administration module ✅
  • Import all data using scheduler ✅
  • Filtering client list ✅
  • Creating a new client ✅

@liayn liayn merged commit b618ae8 into georgringer:master Nov 25, 2025
@liayn liayn deleted the core-v13 branch November 29, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants