-
-
Notifications
You must be signed in to change notification settings - Fork 36
[TASK] Update for Core v13 #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I've tested your Pull request in my TYPO3 12.4.39, composer installation and it crashed my whole installation with: PHP Fatal error: Type of T3Monitor\T3monitoring\Domain\TypeConverter\ClientFilterDemandConverter::$sourceTypes must not be defined (as in class TYPO3\CMS\Extbase\Property\TypeConverter\AbstractTypConverter) in [...]/Classes/Domain/TypeConverter/ClientFilterDemandConverter.php on line 21 Fatal error: Type of T3Monitor\T3monitoring\Domain\TypeConverter\ClientFilterDemandConverter::$sourceTypes must not be defined (as in class TYPOe\CMS\Extbase\Property\TypeConverter\AbstractTypeConverter) in [...]/Classes/Domain/TypeConverter/ClientFilterDemandConverter.php on line 21 |
|
It's a draft and work in progress |
|
@maslme I'd be happy, if you could test this again with your v12 installation. |
|
@liayn There seems to be an issue in TYPO3 12. The client list is empty. Using XDebug in the |
|
@christian-fries Thanks for the test. I know the issue, it's the view being renamed to moduleTemplate due to type incompatibility of the moduleTemplate with viewinterface in Extbase. Will fix |
|
The mentioned problem is solved with the latest changes. I did some spot checks in TYPO3 12, the PR seems to be fine
|

No description provided.