Skip to content

Remove chrono dependency#57

Closed
flosse wants to merge 2 commits into
georust:masterfrom
slowtec:remove-chrono
Closed

Remove chrono dependency#57
flosse wants to merge 2 commits into
georust:masterfrom
slowtec:remove-chrono

Conversation

@flosse

@flosse flosse commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

... and instead of binding the user to a specific time library, the UnixTime should be converted by the user depending on the use case.

uklotzde
uklotzde reviewed Jul 18, 2022
View reviewed changes
Comment thread src/opencage.rs Outdated
@flosse flosse mentioned this pull request Aug 29, 2022
Open
2 tasks
@lnicola

lnicola commented Feb 13, 2023

Copy link
Copy Markdown
Member

r? @urschrei

@lnicola

lnicola commented Feb 14, 2023

Copy link
Copy Markdown
Member

bors r=urschrei,lnicola

@lnicola

lnicola commented Feb 14, 2023

Copy link
Copy Markdown
Member

bors r-

bors Bot added a commit that referenced this pull request Feb 14, 2023
@bors @flosse
Merge #57
27463de 
57: Remove unmentained chrono dependency r=urschrei,lnicola a=flosse

... and instead of binding the user to a specific time library, the `UnixTime` should be converted by the user depending on the use case.

Co-authored-by: Markus Kohlhase <markus.kohlhase@slowtec.de>
@bors

bors Bot commented Feb 14, 2023

Copy link
Copy Markdown
Contributor

Canceled.

lnicola
lnicola reviewed Feb 14, 2023
View reviewed changes
Comment thread CHANGES.md Outdated
@flosse flosse changed the title Remove unmentained chrono dependency Remove chrono dependency Mar 14, 2023
@lnicola

lnicola commented Mar 14, 2023

Copy link
Copy Markdown
Member

bors r=urschrei,lnicola

bors Bot added a commit that referenced this pull request Mar 14, 2023
@bors @flosse
Merge #57
e77a7ac 
57: Remove chrono dependency r=urschrei,lnicola a=flosse

... and instead of binding the user to a specific time library, the `UnixTime` should be converted by the user depending on the use case.

Co-authored-by: Markus Kohlhase <markus.kohlhase@slowtec.de>
@bors

bors Bot commented Mar 14, 2023

Copy link
Copy Markdown
Contributor

Build failed:

@urschrei

urschrei commented Mar 14, 2023

Copy link
Copy Markdown
Member

this version of Cargo is older than the 2021 edition, and only supports 2015 and 2018 editions.

@urschrei

urschrei commented Mar 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

I'm gonna push a fix separately (use same rust versions as geo) so we can get this show on the road.

@urschrei

urschrei commented Mar 14, 2023

Copy link
Copy Markdown
Member

bors retry

bors Bot added a commit that referenced this pull request Mar 14, 2023
@bors @flosse
Merge #57
6b07fa1 
57: Remove chrono dependency r=urschrei,lnicola a=flosse

... and instead of binding the user to a specific time library, the `UnixTime` should be converted by the user depending on the use case.

Co-authored-by: Markus Kohlhase <markus.kohlhase@slowtec.de>
@bors

bors Bot commented Mar 14, 2023

Copy link
Copy Markdown
Contributor

Build failed:

@urschrei

urschrei commented Mar 14, 2023

Copy link
Copy Markdown
Member

now what

@urschrei

urschrei commented Mar 14, 2023

Copy link
Copy Markdown
Member

Ah, these are actual test failures.

@flosse

flosse commented Apr 18, 2023

Copy link
Copy Markdown
Contributor Author

Ah, these are actual test failures.

What's the status of this? Can I help?

@lnicola

lnicola commented Apr 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

I think the latest failed run is https://github.com/georust/geocoding/actions/runs/4416893986/jobs/7741822915. Maybe some API changed a little?

@flosse

flosse commented Apr 18, 2023

Copy link
Copy Markdown
Contributor Author

🤔 It seems to be independent of this PR.

@lnicola

lnicola commented Apr 18, 2023

Copy link
Copy Markdown
Member

Indeed. Without looking at the code, I'd guess that one or more external APIs changed.

@flosse

flosse commented Apr 18, 2023

Copy link
Copy Markdown
Contributor Author

Just rebased on current master

@lnicola

lnicola commented Apr 18, 2023

Copy link
Copy Markdown
Member

I think GitHub is having a bad day, but...

bors retry

bors Bot added a commit that referenced this pull request Apr 18, 2023
@bors @flosse
Merge #57
f36edfc 
57: Remove chrono dependency r=urschrei,lnicola a=flosse

... and instead of binding the user to a specific time library, the `UnixTime` should be converted by the user depending on the use case.

Co-authored-by: Markus Kohlhase <markus.kohlhase@slowtec.de>
@bors

bors Bot commented Apr 18, 2023

Copy link
Copy Markdown
Contributor

Canceled.

@flosse

flosse commented Apr 18, 2023

Copy link
Copy Markdown
Contributor Author

I fixed the clippy lints but a lot of tests are failing locally.

@flosse

flosse commented Apr 18, 2023

Copy link
Copy Markdown
Contributor Author

.. last successful CI build was while ago: 1736b26

@lnicola

lnicola commented Apr 18, 2023

Copy link
Copy Markdown
Member

Yeah, I'm afraid it's broken :(.

@lnicola

lnicola commented Jun 15, 2023

Copy link
Copy Markdown
Member

bors retry

@bors

bors Bot commented Jun 15, 2023

Copy link
Copy Markdown
Contributor

Merge conflict.

@michaelkirk michaelkirk mentioned this pull request Jul 11, 2023
Merged
2 tasks
@michaelkirk

michaelkirk commented Jul 11, 2023

Copy link
Copy Markdown
Member

Merge conflict.

Rebased and conflicts addresses with #60

@michaelkirk

michaelkirk commented Oct 5, 2023

Copy link
Copy Markdown
Member

Superseded by #60

@michaelkirk michaelkirk closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lnicola lnicola lnicola left review comments

@urschrei urschrei urschrei approved these changes

+1 more reviewer

@uklotzde uklotzde uklotzde left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@flosse @lnicola @urschrei @michaelkirk @uklotzde