KmlDocument's version and attributes handling#75
Merged
pjsier merged 3 commits intogeorust:mainfrom Feb 18, 2026
Merged
Conversation
pjsier
reviewed
Feb 15, 2026
Member
pjsier
left a comment
There was a problem hiding this comment.
Thanks for this! Could you add a quick test to verify functionality? Then I think this is good to go
Contributor
Author
|
Sure, I just added one |
pjsier
approved these changes
Feb 18, 2026
Member
pjsier
left a comment
There was a problem hiding this comment.
This looks great! Thanks for adding that test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGES.mdorCHANGELOG.mdToday i tried to use this library and notice that i cannot get document version, so I suggest these changes to fix it. I also provide the attributes to the document for passing the tests