Skip to content

KmlDocument's version and attributes handling#75

Merged
pjsier merged 3 commits intogeorust:mainfrom
NikBel3476:main
Feb 18, 2026
Merged

KmlDocument's version and attributes handling#75
pjsier merged 3 commits intogeorust:mainfrom
NikBel3476:main

Conversation

@NikBel3476
Copy link
Contributor

  • I agree to follow the project's code of conduct.
  • I added an entry to the project's change log file if knowledge of this change could be valuable to users.
    • Usually called CHANGES.md or CHANGELOG.md
    • Prefix changelog entries for breaking changes with "BREAKING: "

Today i tried to use this library and notice that i cannot get document version, so I suggest these changes to fix it. I also provide the attributes to the document for passing the tests

Copy link
Member

@pjsier pjsier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Could you add a quick test to verify functionality? Then I think this is good to go

@NikBel3476
Copy link
Contributor Author

Sure, I just added one

Copy link
Member

@pjsier pjsier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for adding that test

@pjsier pjsier merged commit e19edc0 into georust:main Feb 18, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants