fix: reading mapbox styles #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcjansen
approved these changes
Dec 2, 2025
Contributor
marcjansen
left a comment
marcjansen
left a comment
There was a problem hiding this comment.
Only nit-picks, thanks
test.cjs
Outdated
|
|
||
| console.log(''); | ||
| console.log(''); | ||
| console.log(''); |
Contributor
There was a problem hiding this comment.
This looks strange, is it needed?
Contributor
Author
There was a problem hiding this comment.
This necessary so that we can distinguish the final status of the tests from the status of the last testcase. I just replaced it with a few \n.
src/index.ts
Outdated
| : await promises.readFile(sourceFile, 'utf-8'); | ||
|
|
||
| // If no sourceParser is set, just parse it as JSON - it should already be in geostyler format. | ||
| // LyrxParser expects a JSON object as input, so we need to parse it as an extra step. |
Contributor
There was a problem hiding this comment.
The comment above the if should be updated.
KaiVolland
approved these changes
Dec 2, 2025
Contributor
KaiVolland
left a comment
KaiVolland
left a comment
There was a problem hiding this comment.
please remove the logs as suggested by @marcjansen
|
🎉 This PR is included in version 5.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes reading mapbox styles. We have to parse the mapbox style object first, before passing it to the parser.
solves #461