Added Search and Page Turn on Scroll functionality with Example#193
Merged
gerhardsletten merged 4 commits intogerhardsletten:mainfrom Mar 12, 2025
Merged
Added Search and Page Turn on Scroll functionality with Example#193gerhardsletten merged 4 commits intogerhardsletten:mainfrom
gerhardsletten merged 4 commits intogerhardsletten:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PJ-Vishnu
force-pushed
the
newFeature
branch
from
89fb654 to
92e7311
Compare
… changing search query
Contributor
Author
|
Hi @gerhardsletten , I wanted to follow up on this PR and check if you had a chance to review it. Please let me know if any modifications are needed—I’d be happy to make adjustments based on your feedback. Looking forward to your thoughts and hoping to get this merged. Thanks for your time! |
Owner
|
@PJ-Vishnu Thank you, its now published to |
Contributor
Author
|
@gerhardsletten |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
This PR introduces two key enhancements to ReactReader:
📜 Page Turn on Scroll:
Allows users to navigate through the book by scrolling instead of clicking on 'paginated' document. ( Similar to Kindle )
Smooth, intuitive reading experience.
🔍 Integrated Search Functionality:
Enables full-book search, by utilizing functions in EPUB.js.
Supports navigation to search result.
Added search result highlighting in the example.
This is my first time contributing to a public package, and I’d really appreciate a review of these changes. Let me know if any improvements are needed! Looking forward to your feedback and hopefully getting this merged.
Thank You