Skip to content

Fix typing of View classes#82

Merged
gerlero merged 1 commit intomainfrom
views
Sep 8, 2025
Merged

Fix typing of View classes#82
gerlero merged 1 commit intomainfrom
views

Conversation

@gerlero
Copy link
Copy Markdown
Owner

@gerlero gerlero commented Sep 8, 2025

No description provided.

@gerlero gerlero requested a review from Copilot September 8, 2025 19:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the typing of View classes by updating them to properly inherit from the standard library's mapping view classes while maintaining their custom functionality.

  • Refactored View classes to inherit from standard library view classes (KeysView, ItemsView, ValuesView) instead of custom base classes
  • Updated MultiMappingView to inherit from MappingView and use Any type annotations for broader compatibility
  • Corrected return type annotations for mapping view methods to align with standard library interfaces

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread multicollections/abc.py
@gerlero gerlero merged commit c395e3e into main Sep 8, 2025
11 checks passed
@gerlero gerlero deleted the views branch September 8, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants