Skip to content

Refactor KeysView, ItemsView, and ValuesView imports#83

Merged
gerlero merged 1 commit intomainfrom
typing
Sep 8, 2025
Merged

Refactor KeysView, ItemsView, and ValuesView imports#83
gerlero merged 1 commit intomainfrom
typing

Conversation

@gerlero
Copy link
Copy Markdown
Owner

@gerlero gerlero commented Sep 8, 2025

No description provided.

@gerlero gerlero requested a review from Copilot September 8, 2025 20:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the import pattern for mapping view classes (KeysView, ItemsView, and ValuesView) to avoid naming conflicts with locally defined classes that have the same names.

  • Imports KeysView, ItemsView, and ValuesView from collections.abc and typing with aliased names
  • Updates class inheritance to use the aliased mapping view classes instead of the original names
  • Removes type: ignore comments that were previously needed due to name redefinition

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gerlero gerlero merged commit 1959c54 into main Sep 8, 2025
12 checks passed
@gerlero gerlero deleted the typing branch September 8, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants