Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes mypy type checking errors by updating the MethodWithDefault protocol definition and its usage. The changes simplify the generic type parameters and ensure consistency between the protocol definition and its return type annotation.
- Removed the
_Self_cocovariant type variable and replaced it with a standard_Selftype variable - Updated the
MethodWithDefaultprotocol to use fewer generic parameters - Fixed the return type annotation in the
with_defaultfunction to match the updated protocol signature
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| multicollections/_typing.py | Updated MethodWithDefault protocol definition and replaced covariant _Self_co with standard _Self |
| multicollections/abc.py | Fixed return type annotation to match the updated MethodWithDefault protocol signature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 352 352
=========================================
Hits 352 352 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.