Skip to content

Fix mypy errors#84

Merged
gerlero merged 1 commit intomainfrom
typing
Sep 17, 2025
Merged

Fix mypy errors#84
gerlero merged 1 commit intomainfrom
typing

Conversation

@gerlero
Copy link
Copy Markdown
Owner

@gerlero gerlero commented Sep 17, 2025

No description provided.

@gerlero gerlero requested a review from Copilot September 17, 2025 17:44
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes mypy type checking errors by updating the MethodWithDefault protocol definition and its usage. The changes simplify the generic type parameters and ensure consistency between the protocol definition and its return type annotation.

  • Removed the _Self_co covariant type variable and replaced it with a standard _Self type variable
  • Updated the MethodWithDefault protocol to use fewer generic parameters
  • Fixed the return type annotation in the with_default function to match the updated protocol signature

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
multicollections/_typing.py Updated MethodWithDefault protocol definition and replaced covariant _Self_co with standard _Self
multicollections/abc.py Fixed return type annotation to match the updated MethodWithDefault protocol signature

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread multicollections/_typing.py
Comment thread multicollections/_typing.py
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (986fa9a) to head (5f0fd0b).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #84   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          352       352           
=========================================
  Hits           352       352           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gerlero gerlero merged commit f7b269c into main Sep 17, 2025
12 checks passed
@gerlero gerlero deleted the typing branch September 17, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants