Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 352 352
=========================================
Hits 352 352 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves type annotations in the multicollections test file by replacing generic MutableMultiMapping type hints with specific union types for the actual classes being tested. The changes remove the need for # type: ignore[call-arg] comments throughout the test file by providing more accurate type information.
Key changes:
- Replace
MutableMultiMapping[K, V]type annotations with specific unions likeMultiDict[K, V] | ListMultiDict[K, V] | multidict.MultiDict[V] - Remove
# type: ignorecomments that are no longer needed due to improved typing - Fix a type annotation inconsistency in one test function parameter
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
54a109d to
fedd79d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.