Skip to content

Improve typing of tests#85

Merged
gerlero merged 1 commit intomainfrom
typing
Sep 19, 2025
Merged

Improve typing of tests#85
gerlero merged 1 commit intomainfrom
typing

Conversation

@gerlero
Copy link
Copy Markdown
Owner

@gerlero gerlero commented Sep 19, 2025

No description provided.

@gerlero gerlero requested a review from Copilot September 19, 2025 01:05
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (5e2e395) to head (e5932ca).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #85   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          352       352           
=========================================
  Hits           352       352           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves type annotations in the multicollections test file by replacing generic MutableMultiMapping type hints with specific union types for the actual classes being tested. The changes remove the need for # type: ignore[call-arg] comments throughout the test file by providing more accurate type information.

Key changes:

  • Replace MutableMultiMapping[K, V] type annotations with specific unions like MultiDict[K, V] | ListMultiDict[K, V] | multidict.MultiDict[V]
  • Remove # type: ignore comments that are no longer needed due to improved typing
  • Fix a type annotation inconsistency in one test function parameter

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread tests/test_multicollections.py
Comment thread tests/test_multicollections.py Outdated
@gerlero gerlero force-pushed the typing branch 4 times, most recently from 54a109d to fedd79d Compare September 19, 2025 01:12
@gerlero gerlero merged commit 55acd68 into main Sep 19, 2025
12 checks passed
@gerlero gerlero deleted the typing branch September 19, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants