Skip to content

Switch to ty for type checking#86

Merged
gerlero merged 2 commits intomainfrom
typing
Sep 21, 2025
Merged

Switch to ty for type checking#86
gerlero merged 2 commits intomainfrom
typing

Conversation

@gerlero
Copy link
Copy Markdown
Owner

@gerlero gerlero commented Sep 21, 2025

No description provided.

@gerlero gerlero requested a review from Copilot September 21, 2025 14:10
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (55acd68) to head (eee9300).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #86   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          352       352           
=========================================
  Hits           352       352           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR switches the type checker from mypy to ty for the multicollections project. The change involves updating dependencies, type ignore comments, and fixing various type checking issues that arise with the new type checker.

  • Replace mypy with ty as the project's type checker
  • Update type ignore comments from mypy syntax to ty syntax
  • Fix type checking issues revealed by ty's different analysis

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pyproject.toml Replace mypy dependency with ty
README.md Update badge from mypy to ty
tests/test_multicollections.py Remove unnecessary type ignore comment
tests/minimalimpl.py Update type ignore comments to ty syntax
multicollections/abc.py Update type ignore comments and fix type checking issues
multicollections/init.py Update type ignore comments and fix multi-line expression formatting

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread multicollections/abc.py
Comment thread multicollections/__init__.py Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@gerlero gerlero merged commit fcd1695 into main Sep 21, 2025
12 checks passed
@gerlero gerlero deleted the typing branch September 21, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants