Conversation
- Unify protocol generation: TS → JSON Schema → Pydantic - Human‑readable union variants (EventMsg*, ClientRequest*, …) - Remove old TS→Python generator script and flow - Add dev tooling: datamodel-code-generator; post-processors for schema/types - Bump crate and package version to 0.2.12
- Optional fields: change Field(...) to Field(None, ...) for types including None - Union wrappers: add model_rebuild() calls post-generation to resolve forward refs - Schema gen: pass --tsconfig to ts-json-schema-generator for stable module resolution
- Generator: use index.ts for --path and pass --tsconfig to ts-json-schema-generator - Schema postprocess: hoist titles and relax for nullable fields; print summary - Types postprocess: dedupe duplicate model_rebuild() calls; print summary
Contributor
|
Codex Autonomous Review:
The changes introduce a new schema generation pipeline, regenerate protocol models with Pydantic v2, add supporting scripts and a small Rust helper binary, and update metadata. The diffs are internally consistent and do not reveal discrete correctness, type, or runtime issues in the modified lines. |
Owner
Author
|
@codex the review actions seems to be running twice - can we fix this? |
gersmann
added a commit
that referenced
this pull request
Sep 14, 2025
* chore(release): 0.2.12 - Unify protocol generation: TS → JSON Schema → Pydantic - Human‑readable union variants (EventMsg*, ClientRequest*, …) - Remove old TS→Python generator script and flow - Add dev tooling: datamodel-code-generator; post-processors for schema/types - Bump crate and package version to 0.2.12 * fix: address PR feedback - Optional fields: change Field(...) to Field(None, ...) for types including None - Union wrappers: add model_rebuild() calls post-generation to resolve forward refs - Schema gen: pass --tsconfig to ts-json-schema-generator for stable module resolution * fix: make codegen robust and dedupe - Generator: use index.ts for --path and pass --tsconfig to ts-json-schema-generator - Schema postprocess: hoist titles and relax for nullable fields; print summary - Types postprocess: dedupe duplicate model_rebuild() calls; print summary * fix(postprocess): correct base for vs definitions and print summary * fix(postprocess): stop injecting noqa on root line to preserve Field(...) metadata * fix(postprocess): stop injecting noqa on root line to preserve Field(...) metadata * fix(schema): enforce RequestId as string|integer; improve schema postprocess summary * fix(schema): coerce ExecCommandEndEvent.exit_code to integer
Summary
Testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.