Add a new GitHub action to lint workflows#69
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: get-convex/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis pull request adds a new GitHub Actions workflow to lint workflow and action files using actionlint and zizmor, with concurrency control and read-only contents permission. It also updates the existing test workflow to set workflow-level permissions to empty and to disable credential persistence in the actions/checkout step. Sequence Diagram(s)sequenceDiagram
participant ComponentA
participant ComponentB
ComponentA->>ComponentB: observable interaction
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/lint-workflows.yml (1)
3-5: ⚡ Quick winUse a stable concurrency key for push events.
github.run_idis unique per run, socancel-in-progresswon’t cancel earlier runs onpush. Usegithub.refas fallback to actually dedupe branch runs.Suggested diff
concurrency: - group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} + group: ${{ github.workflow }}-${{ github.head_ref || github.ref }} cancel-in-progress: true🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/lint-workflows.yml around lines 3 - 5, The concurrency group uses github.run_id which is run-unique and prevents cancel-in-progress from deduping push events; change the fallback from github.run_id to github.ref so branch refs are used for push workflows (update the concurrency group expression where "group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}" is defined to use github.ref instead of github.run_id).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/lint-workflows.yml:
- Around line 3-5: The concurrency group uses github.run_id which is run-unique
and prevents cancel-in-progress from deduping push events; change the fallback
from github.run_id to github.ref so branch refs are used for push workflows
(update the concurrency group expression where "group: ${{ github.workflow
}}-${{ github.head_ref || github.run_id }}" is defined to use github.ref instead
of github.run_id).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: get-convex/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4f9ed53e-e768-45ad-a5a1-04ddf84990f0
📒 Files selected for processing (2)
.github/workflows/lint-workflows.yml.github/workflows/test.yml
|
is this specifically needed for action-cache? or just a trial of something we'd want for all components? |
* Add a new GitHub action to lint workflows * Fix workflows
* Add a new GitHub action to lint workflows (#69) * Add a new GitHub action to lint workflows * Fix workflows * Fix actions/checkout
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.