full-app tsc #227
Merged
full-app tsc #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sujayakar
reviewed
Apr 10, 2025
app/lib/runtime/action-runner.ts
Outdated
|
|
||
| { | ||
| // Typecheck convex functions and deploy | ||
| const convexProc = await container.spawn('npx', ['convex', 'dev', '--once']); |
There was a problem hiding this comment.
might it be a little better to do something like...
spawn('sh', ['-c', 'tsc --noEmit -p tsconfig.app.json && convex dev --once'])
so we have a single process?
Collaborator
Author
There was a problem hiding this comment.
and that still short-circuits, sure we can do that
Collaborator
Author
There was a problem hiding this comment.
I'm worried about changing the order to do app typescript first because we need to codegen first but I'm not sure how codegen works for CONVEX_DEPLOY_KEY etc., it's just a different flow that we've done all week
Collaborator
Author
There was a problem hiding this comment.
I'm worried about changing the order, we need a codegen to typecheck and I'm not sure if typecheck deals with all the CONVEX_DEPLOY_KEY well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.