-
Notifications
You must be signed in to change notification settings - Fork 58
Improve documentation of Zod #824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
commit: |
| * | **zodToConvex** | {@link zodOutputToConvex} | | ||
| * | ------------------------------------------------------------------------------------------------------ | --------------------------------------------------------------------------------------------------------------------- | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This table is so wide it's hard to read - let's try to make the docs readable with 80 character width display. likely means making this into a more concise table, inline the differences in one list, or something similar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed it in 4114d16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry I forgot to merge this earlier, looks great!
|
only nit: the missing CLA test we should either update to not require for employees, or if you could add it to your descriptions then it won't be a red herring |
No description provided.