Skip to content

fix(eventually-postgres): flaky integration test for event_store.rs #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2023
Merged

fix(eventually-postgres): flaky integration test for event_store.rs #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68baa30
fix(event): remove trailing parenthesis from AppendError
ar3s3ru Mar 2, 2023
1d0ce39
fix(tests/event_store): use if-let-else for result assertion in case …
ar3s3ru Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eventually-postgres/src/event.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ pub enum StreamError {

#[derive(Debug, thiserror::Error)]
pub enum AppendError {
#[error("conflict error detected: {0})")]
#[error("conflict error detected: {0}")]
Conflict(#[source] version::ConflictError),
#[error("concurrent update detected, represented as a conflict error: {0})")]
#[error("concurrent update detected, represented as a conflict error: {0}")]
Concurrency(#[source] version::ConflictError),
#[error("failed to begin transaction: {0}")]
BeginTransaction(#[source] sqlx::Error),
Expand Down
14 changes: 5 additions & 9 deletions eventually-postgres/tests/event_store.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,15 +182,11 @@ async fn it_handles_concurrent_writes_to_the_same_stream() {

match result {
(Ok(_), Err(err)) | (Err(err), Ok(_)) => {
let expected_err = event::AppendError::Concurrency(version::ConflictError {
expected: 0,
actual: 1,
});

let actual_err_msg = format!("{}", err);
let expected_err_msg = format!("{}", expected_err);

assert_eq!(expected_err_msg, actual_err_msg);
if let event::AppendError::Conflict(_) | event::AppendError::Concurrency(_) = err {
// This is the expected scenario :)
} else {
panic!("unexpected error, {:?}", err);
}
}
(first, second) => panic!(
"invalid state detected, first: {:?}, second: {:?}",
Expand Down