Skip to content

feat: move versioning check on the EventStore#79

Merged
ar3s3ru merged 5 commits intomasterfrom
fix-versioning
Aug 6, 2020
Merged

feat: move versioning check on the EventStore#79
ar3s3ru merged 5 commits intomasterfrom
fix-versioning

Conversation

@ar3s3ru
Copy link
Copy Markdown
Collaborator

@ar3s3ru ar3s3ru commented Aug 6, 2020

Closes #62

NOTE: this PR breaks eventually-postgres, which should go on a full overhaul.

@ar3s3ru ar3s3ru added feature New feature or request eventually-core Issue or Pull Request involves eventually-core crate eventually-util Issue or Pull Request involves eventually-util crate eventually-postgres Issue or Pull Request involves eventually-util crate labels Aug 6, 2020
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 6, 2020

Codecov Report

Merging #79 into master will increase coverage by 2.14%.
The diff coverage is 47.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   17.66%   19.81%   +2.14%     
==========================================
  Files          12       12              
  Lines         402      424      +22     
==========================================
+ Hits           71       84      +13     
- Misses        331      340       +9     
Impacted Files Coverage Δ
eventually-core/src/repository.rs 0.00% <0.00%> (ø)
eventually-postgres/src/lib.rs 0.00% <0.00%> (ø)
eventually-test/src/api.rs 0.00% <0.00%> (ø)
eventually-test/src/main.rs 0.00% <0.00%> (ø)
eventually-core/src/store.rs 22.72% <21.42%> (-37.28%) ⬇️
eventually-util/src/inmemory.rs 79.79% <78.26%> (-5.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45a8212...b026849. Read the comment docs.

@ar3s3ru ar3s3ru changed the title Fix versioning feat: move versioning check on the EventStore Aug 6, 2020
@ar3s3ru ar3s3ru merged commit 63c86d8 into master Aug 6, 2020
@ar3s3ru ar3s3ru deleted the fix-versioning branch August 6, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eventually-core Issue or Pull Request involves eventually-core crate eventually-postgres Issue or Pull Request involves eventually-util crate eventually-util Issue or Pull Request involves eventually-util crate feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix versioning strategy

1 participant