Skip to content

feat: rename to store::Persisted and proper error handling for Id in eventually-postgres#90

Merged
ar3s3ru merged 3 commits intomasterfrom
feature/eventually-postgres-overhaul
Aug 12, 2020
Merged

feat: rename to store::Persisted and proper error handling for Id in eventually-postgres#90
ar3s3ru merged 3 commits intomasterfrom
feature/eventually-postgres-overhaul

Conversation

@ar3s3ru
Copy link
Copy Markdown
Collaborator

@ar3s3ru ar3s3ru commented Aug 12, 2020

No description provided.

@ar3s3ru ar3s3ru added eventually-core Issue or Pull Request involves eventually-core crate eventually-postgres Issue or Pull Request involves eventually-util crate feature New feature or request labels Aug 12, 2020
@ar3s3ru ar3s3ru added this to the v0.4.0 milestone Aug 12, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 12, 2020

Codecov Report

Merging #90 into master will decrease coverage by 1.46%.
The diff coverage is 39.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
- Coverage   48.63%   47.16%   -1.47%     
==========================================
  Files          13       13              
  Lines         584      600      +16     
==========================================
- Hits          284      283       -1     
- Misses        300      317      +17     
Flag Coverage Δ
#unit 47.16% <39.18%> (-1.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
eventually-postgres/src/lib.rs 0.00% <0.00%> (ø)
eventually-test/src/api.rs 13.08% <0.00%> (ø)
eventually-core/src/store.rs 41.37% <44.44%> (ø)
eventually-util/src/inmemory.rs 90.79% <89.47%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8b031e...efd09d9. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ar3s3ru ar3s3ru merged commit 87b767e into master Aug 12, 2020
@ar3s3ru ar3s3ru deleted the feature/eventually-postgres-overhaul branch August 12, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eventually-core Issue or Pull Request involves eventually-core crate eventually-postgres Issue or Pull Request involves eventually-util crate feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant