docs(examples): unblock 3 up canaries (compose layout, env-var, stderr capture)#121
Merged
Conversation
…r capture) - compose-basic, compose-profiles: rename `devcontainer.json` → `.devcontainer.json` so config discovery finds them (same pattern as #104/#110/#116). - compose-profiles: `run COMPOSE_PROFILES=… cmd` doesn't propagate the env var because `run` sees it as a positional. Use `env` to set it. - gpu-modes: redirect stderr to a temp log instead of `2>&1` inside `$( … )` — post-#114, stderr no longer accidentally contains the result JSON, so the prior captures muddled the JSON with logs and defeated python's parse. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 task
pofallon
added a commit
that referenced
this pull request
May 28, 2026
Four additions captured from a 13-PR / 13-issue spec-compliance grind: - "Canary Patterns" under Examples Hygiene — the four bash/python fixture pitfalls fixed in #104/#110/#115/#121 (config layout, heredoc vs `-c`, `2>&1` inside `$(...)`, env-var wrapping). - "Verified Non-Bugs" — three cases that look like bugs but aren't, with the empirical / spec rationale (ContainerIdentity walking, enum-like fields not substituted, down leaving markers). Prevents the rediscover-and-investigate loop. - "Cross-Cutting Audits" under Common Development Tasks — the parallel- Explore-agent pattern that produced PRs #125 and #127, plus the five pattern axes worth re-running and a "verify empirically" caveat for agent claims. - New-string-field checklist under Pre-Implementation Checklist — when adding `String`/`Option<String>` to `DevContainerConfig` or `FeatureMetadata`, decide template vs identifier, and substitute via the pattern from #122 / #125. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small canary fixture fixes found while running the up suite post-#120.
Summary
Test plan
🤖 Generated with Claude Code