docs(examples): fix invalid python one-liner in with-features canary#144
Merged
Conversation
The `extract_container_id` helper passed an invalid `python3 -c` program — `if`/`try` compound statements joined with semicolons (`if lines:; try:; …`), which raises `SyntaxError`, and it also assumed line-delimited JSON when `deacon up` prints a single pretty-printed JSON document. Replace it with a valid one-liner that parses the whole stdout as one JSON document and reads `containerId`; on any parse error python exits non-zero and the existing `|| json_out=""` falls back to docker label discovery. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/up/with-features/exec.sh'sextract_container_idpassed an invalidpython3 -cprogram:if/trycompound statements joined with semicolons (if lines:; try:; …), which raisesSyntaxError. It also assumed line-delimited JSON, butdeacon upprints a single pretty-printed JSON document.Fix
Replace it with a valid one-liner that parses the whole stdout as one JSON document and reads
containerId. On any parse error python exits non-zero and the existing|| json_out=""falls back to docker label discovery.Testing
with-featurescanary now runs all three scenarios with noSyntaxError, exit 0.Docs/examples only.
🤖 Generated with Claude Code