Defer keychain access until user clicks Connect on plan tab#338
Merged
Conversation
Adds a `dormant` state to SubscriptionLoadState so the menubar never prompts for keychain permission on launch. Users must navigate to the plan tab and click "Load Quota" / "Connect" to trigger credential access. Also fixes a flaky TZ-boundary test (cli-status-menubar) by widening the time offset to avoid generating timestamps in the future at UTC hour 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dormantSubscriptionLoadState so the menubar never prompts for keychain on launchcli-status-menubartest that failed at UTC hour 0 due to timestamps landing in the futureTest plan