fix(menubar): use SupportedCurrency enum in settings picker#435
Merged
Conversation
The currency picker hardcoded 8 currencies while the SupportedCurrency enum defines 18. New currencies added to the enum (like CNY in #430) required a separate SettingsView edit to appear in the picker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SupportedCurrency.allCases"USD — US Dollar"style for clarityContext
Follow-up to #430 (CNY support). The picker was a hardcoded subset that drifted out of sync with the
SupportedCurrencyenum — a pre-existing issue surfaced during review.Test plan
swift buildpassesSupportedCurrencyconforms toCaseIterable+Identifiable