Skip to content

consensus/pbft: start engine failed if i'm not in validator set #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2017
Merged

consensus/pbft: start engine failed if i'm not in validator set #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion consensus/pbft/backends/simple/engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ var (
errUnknownBlock = errors.New("unknown block")
// errUnauthorized is returned if a header is signed by a non authorized entity.
errUnauthorized = errors.New("unauthorized")
// errNotInValidatorSet is returned if I'm not in validator set but try to start engine
errNotInValidatorSet = errors.New("not in validator set")
// errInvalidDifficulty is returned if the difficulty of a block is not 1
errInvalidDifficulty = errors.New("invalid difficulty")
// errNotProposer is returned when I'm not a proposer
Expand Down Expand Up @@ -435,6 +437,9 @@ func (sb *simpleBackend) Start(chain consensus.ChainReader, inserter func(block
if err := sb.initValidatorSet(chain); err != nil {
return err
}
if _, v := sb.valSet.GetByAddress(sb.address); v == nil {
return errNotInValidatorSet
}
sb.chain = chain
sb.inserter = inserter
sb.core = pbftCore.New(sb, sb.config)
Expand All @@ -455,7 +460,10 @@ func (sb *simpleBackend) Start(chain consensus.ChainReader, inserter func(block

// Stop implements consensus.PBFT.Stop
func (sb *simpleBackend) Stop() error {
return sb.core.Stop()
if sb.core != nil {
return sb.core.Stop()
}
return nil
}

func (sb *simpleBackend) initValidatorSet(chain consensus.ChainReader) error {
Expand Down