Skip to content

Conversation

@kgilpin
Copy link
Contributor

@kgilpin kgilpin commented Oct 4, 2024

Logical Changes

  • Extended Binary File Extensions List

    Added more file extensions to the list of BINARY_FILE_EXTENSIONS.

  • Introduced Data File Extensions List

    Introduced a new list DATA_FILE_EXTENSIONS.

  • Refactored File Filtering Logic

    Created helper functions isBinaryFile and isDataFile to streamline file filtering.

  • Updated File Filtering Method

    Enhanced filterFiles function to exclude large data files.

  • Extended Unit Tests

    Modified and added unit tests to cover new filtering logic for binary and data files.

  • Added Test Case for Regex Patterns

    Added a new test case in the pattern matching tests.

Possible Bugs to Investigate

Checked-off items have been reviewed by the developer and determined to be non-issues.

  • Missing Extensions: There is a risk of missing certain binary or data file extensions that are not included in the current lists.
  • Hardcoded File Size Threshold: The file size threshold (50,000 bytes) is hardcoded and may not be suitable for all scenarios.
  • Performance Impact: Iterating through large arrays of file names and extensions could impact performance.
  • Error Handling: The catch block in filterFiles logs an error but continues processing. Ensure this behavior is intended.
  • Test Coverage: Ensure all edge cases are covered in unit tests, particularly for newly introduced file types and size-based exclusions.

Fixes #2039

@kgilpin kgilpin requested a review from dustinbyrne October 4, 2024 17:00
@kgilpin kgilpin self-assigned this Oct 4, 2024
@kgilpin kgilpin added the enhancement New feature or request label Oct 4, 2024
@kgilpin kgilpin marked this pull request as draft October 4, 2024 17:33
@kgilpin kgilpin force-pushed the feat/ignore-large-data-files branch from ef9510b to a2fd6a3 Compare October 4, 2024 17:38
@kgilpin kgilpin force-pushed the feat/ignore-large-data-files branch from a2fd6a3 to 4b10599 Compare October 6, 2024 13:26
@kgilpin kgilpin marked this pull request as ready for review October 6, 2024 13:26
@kgilpin kgilpin merged commit 2f26d66 into main Oct 6, 2024
@kgilpin kgilpin deleted the feat/ignore-large-data-files branch October 6, 2024 14:34
@appland-release
Copy link
Contributor

🎉 This PR is included in version @appland/appmap-v3.168.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FileIndex emits large file warnings

3 participants