fix: Correctly quote NODE_OPTIONS when spaces occur in paths#129
Merged
dividedmind merged 1 commit intomainfrom Mar 19, 2024
Merged
fix: Correctly quote NODE_OPTIONS when spaces occur in paths#129dividedmind merged 1 commit intomainfrom
dividedmind merged 1 commit intomainfrom
Conversation
dividedmind
force-pushed
the
fix/spaces-in-paths
branch
from
841646f to
414f407
Compare
dividedmind
force-pushed
the
fix/spaces-in-paths
branch
from
414f407 to
419c5bb
Compare
This had a workaround but it turns out that it is in fact our bug. Fixes #122
dividedmind
force-pushed
the
fix/spaces-in-paths
branch
from
419c5bb to
ca9d606
Compare
zermelo-wisen
approved these changes
Mar 18, 2024
Contributor
zermelo-wisen
left a comment
zermelo-wisen
left a comment
There was a problem hiding this comment.
Great job!
Seems like the register.js path was the cause. Can't believe I didn't check it, even if I suspected. I was blinded by similar space in path errors reported about npm.
Now I tested it on Windows machine and it definitely works.
Collaborator
Author
Yeah, it kept bugging me that we couldn't find an issue in npx so I looked into it and there it was :) |
|
🎉 This PR is included in version 2.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #122
Note: after merging, the workaround should be removed from docs.