Exception support, emit metadata.exception#36
Merged
dividedmind merged 10 commits intomainfrom Nov 25, 2023
Merged
Conversation
Node doesn't have user-visible object ids, but since they can be quite useful for data tracking we can generate them sequentially.
This is enabled with NODE_DEBUG=appmap.
Use the fact that generated code won't map to a source file (if a source map is present) to automatically ignore it. Also, instead of crawling the entire source tree and fixing up all node locations with the source map, only consult it when necessary for accurate location of recorded functions. Resolving locations with source maps is expensive and most of the work involved with the tree crawl has been wasted.
dividedmind
force-pushed
the
feat/metadata-exception
branch
from
9194b15 to
0d649ef
Compare
zermelo-wisen
approved these changes
Nov 24, 2023
zermelo-wisen
previously approved these changes
Nov 24, 2023
zermelo-wisen
approved these changes
Nov 25, 2023
Contributor
zermelo-wisen
left a comment
zermelo-wisen
left a comment
There was a problem hiding this comment.
I went through each commit individually, looks good, thank you.
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And assorted other improvements. I suggest reviewing per-commit.
Fixes #26