Skip to content

Fix/windows support#89

Merged
dividedmind merged 3 commits intomainfrom
fix/windows-support
Jan 24, 2024
Merged

Fix/windows support#89
dividedmind merged 3 commits intomainfrom
fix/windows-support

Conversation

@zermelo-wisen
Copy link
Copy Markdown
Contributor

Fixes #74

@dividedmind
Copy link
Copy Markdown
Collaborator

@zermelo-wisen is this done? It's still marked as draft.

@zermelo-wisen zermelo-wisen marked this pull request as ready for review January 19, 2024 17:48
Copy link
Copy Markdown
Collaborator

@dividedmind dividedmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I find a couple of the changes puzzling, could use some more comments.

Comment thread .github/workflows/ci.yml Outdated
Comment thread src/PackageMatcher.ts Outdated
Comment thread src/PackageMatcher.ts
Comment thread src/Recording.ts Outdated
Comment thread src/__tests__/config.test.ts Outdated
Comment thread test/helpers.ts Outdated
Comment thread test/httpServer.test.ts Outdated
Comment thread test/next.test.ts
Comment thread test/next.test.ts Outdated
Comment thread test/simple.test.ts Outdated
@zermelo-wisen zermelo-wisen force-pushed the fix/windows-support branch 2 times, most recently from bcadfd3 to 2c22b48 Compare January 23, 2024 18:36
@zermelo-wisen zermelo-wisen force-pushed the fix/windows-support branch 6 times, most recently from e5dbb77 to ee4f3f4 Compare January 24, 2024 11:03
Copy link
Copy Markdown
Collaborator

@dividedmind dividedmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dividedmind dividedmind merged commit 7d88965 into main Jan 24, 2024
@dividedmind dividedmind deleted the fix/windows-support branch January 24, 2024 13:48
appland-release pushed a commit that referenced this pull request Jan 24, 2024
# [2.14.0](v2.13.2...v2.14.0) (2024-01-24)

### Bug Fixes

* Hook next with a webpack instead of hooking swc ([9b44adf](9b44adf)), closes [#76](#76)
* Windows support ([#89](#89)) ([7d88965](7d88965))

### Features

* Packages in the classmap now model directories exclusively ([0786a48](0786a48)), closes [#93](#93)
* Replace spaces in filenames with underscores ([734a5eb](734a5eb)), closes [#94](#94)
@appland-release
Copy link
Copy Markdown

🎉 This PR is included in version 2.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows support

4 participants