fix: Avoid querying database version when executing client queries #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note I noticed that the smoke test now pulled flask 2 and failed. I forced using flask 1 in the test and created an issue for this: #160 |
While I couldn't reproduce it, a user has reported seeing a stack overflow while processing an SQL query with MySQL and django. It seems to have been caused by appmap querying for the server version, which entails another SQL query against the server with MySQL. Since MySQL backend caches that information, querying it when first establishing the connection ensures the additional query is avoided later at runtime, thus avoiding this problem. Fixes #158
dividedmind
force-pushed
the
158-cannot-recover-from-stack-overflow-error-running-pytest-with-django-and-mysql
branch
from
3444d63 to
5d72861
Compare
dividedmind
deleted the
158-cannot-recover-from-stack-overflow-error-running-pytest-with-django-and-mysql
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I couldn't reproduce it, a user has reported seeing a stack
overflow while processing an SQL query with MySQL and django. It
seems to have been caused by appmap querying for the server version,
which entails another SQL query against the server with MySQL.
Since MySQL backend caches that information, querying it when first
establishing the connection ensures the additional query is avoided
later at runtime, thus avoiding this problem.
Fixes #158