docs: add documentations for v1.19.0#380
Conversation
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Preview deployed successfully! Built from commit 60f1e44 |
e97b379 to
8b430e5
Compare
| sudo tee /etc/yum.repos.d/arcane.repo << 'EOF' | ||
| [arcane] | ||
| name=Arcane Repository | ||
| baseurl=https://pkgs.getarcane.app/repository/yum/$basearch/ | ||
| enabled=1 | ||
| gpgcheck=0 | ||
| EOF |
There was a problem hiding this comment.
The YUM/DNF repo config disables GPG package verification with
gpgcheck=0, while the APT section correctly sets up signature checking with a keyring. Any user who follows these instructions on RHEL/Fedora/CentOS will install packages without verifying their authenticity, leaving them open to tampered packages from a MITM or a compromised mirror. The signing key URL is already served from pkgs.getarcane.app, so it can simply be referenced here.
| sudo tee /etc/yum.repos.d/arcane.repo << 'EOF' | |
| [arcane] | |
| name=Arcane Repository | |
| baseurl=https://pkgs.getarcane.app/repository/yum/$basearch/ | |
| enabled=1 | |
| gpgcheck=0 | |
| EOF | |
| sudo tee /etc/yum.repos.d/arcane.repo << 'EOF' | |
| [arcane] | |
| name=Arcane Repository | |
| baseurl=https://pkgs.getarcane.app/repository/yum/$basearch/ | |
| enabled=1 | |
| gpgcheck=1 | |
| gpgkey=https://pkgs.getarcane.app/repository/raw/arcane-repo-signing.asc | |
| EOF |
Prompt To Fix With AI
This is a comment left during a code review.
Path: content/cli/install.md
Line: 69-75
Comment:
The YUM/DNF repo config disables GPG package verification with `gpgcheck=0`, while the APT section correctly sets up signature checking with a keyring. Any user who follows these instructions on RHEL/Fedora/CentOS will install packages without verifying their authenticity, leaving them open to tampered packages from a MITM or a compromised mirror. The signing key URL is already served from `pkgs.getarcane.app`, so it can simply be referenced here.
```suggestion
sudo tee /etc/yum.repos.d/arcane.repo << 'EOF'
[arcane]
name=Arcane Repository
baseurl=https://pkgs.getarcane.app/repository/yum/$basearch/
enabled=1
gpgcheck=1
gpgkey=https://pkgs.getarcane.app/repository/raw/arcane-repo-signing.asc
EOF
```
How can I resolve this? If you propose a fix, please make it concise.
Disclaimer Greptiles Reviews use AI, make sure to check over its work.
To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike
To have Greptile Re-Review the changes, mention
greptileai.Greptile Summary
This PR adds v1.19.0 documentation: new APT and YUM/DNF installation sections for the CLI, a full mTLS edge-agent guide (
security/edge-mtls.md), and the corresponding nav entry indocs.ts.gpgcheck=0, which disables GPG package signature verification; the APT section correctly wires up a keyring andSigned-By, so parity is expected here.src/lib/config/docs.tscorrectly adds the new page to the Security navigation group.Confidence Score: 3/5
The mTLS documentation and nav change are safe; the YUM/DNF install snippet actively instructs users to disable package signature verification, which needs to be corrected before the page goes live.
The new mTLS guide and nav entry are well-written and pose no correctness concerns. However, the YUM/DNF repo snippet ships
gpgcheck=0— unlike the APT section, which properly configures a signing key — meaning every RPM-based user who follows this guide will install the CLI without any package integrity check. Fixing this before publication is important given this is a security product's documentation.content/cli/install.md — the YUM/DNF repo block needs GPG verification enabled before the page is published.
Security Review
content/cli/install.md): The YUM/DNF repository configuration disables GPG signature verification for installed packages. The APT section correctly uses a keyring andSigned-By; the RPM section should match it by enabling signature checking and pointing to the signing key already hosted onpkgs.getarcane.app.Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "docs: add documentations for v1.19.0" | Re-trigger Greptile