Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates permission-related endpoints by merging sendMessage/toolUse/permission into sendMessage/toolUse/permission/acp. The change simplifies routing logic and fixes an issue where calls from Codex were not being routed correctly.
Key Changes:
- Removed the old
/sendMessage/toolUse/permissionendpoint and migrated functionality to/sendMessage/toolUse/permission/acp - Extracted
pendingToolApprovalRequestsinto a shared module to enable reuse across implementations - Updated all client code and tests to use the new unified endpoint
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| local-server/src/server/server.ts | Renamed import from plural registerACPClientEndpoints to singular registerACPClientEndpoint |
| local-server/src/server/endpoints/sendMessage/sendMessage.ts | Removed registerClaudeCodeEndpoint import and registration call |
| local-server/src/server/endpoints/sendMessage/pendingToolApprovalRequests.ts | New shared module exporting pendingToolApprovalRequests map |
| local-server/src/server/endpoints/sendMessage/claudeCode/sendMessageToClaudeCode.ts | Removed local pendingToolApprovalRequests and endpoint registration, now imports from shared module |
| local-server/src/server/endpoints/sendMessage/claudeCode/tests/sendMessageToClaudeCode.test.ts | Updated tests to import registerEndpoint from ACPClient and reference new endpoint path |
| local-server/src/server/endpoints/sendMessage/acp/clients/ACPClient.ts | Replaced local pendingToolApprovalRequests with import from shared module |
| local-server/build.size | Reflects reduced bundle size from code consolidation |
| local-server/build.sha256 | Updated build hash |
| app/modules/services/LLMService/Tests/RequestStreamingHelperTests.swift | Updated test to expect new endpoint path |
| app/modules/services/LLMService/Sources/RequestStreamingHelper.swift | Removed conditional routing logic, now always uses /acp endpoint |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sendMessage/toolUse/permission->sendMessage/toolUse/permission/acpThis simplifies the code, and resolves an issue where calls from Codex would not be routed correctly