Now both workflows read the full version directly from the manifest:#10
Merged
Conversation
- VSCode: apps/vscode/package.json `version` - JetBrains: apps/jetbrains/gradle.properties `pluginVersion` Before publishing, each workflow checks that the `vscode-v<version>` / `jetbrains-v<version>` tag does not already exist locally or on origin, and fails fast with a clear message asking the maintainer to bump the manifest if it does. Gradle no longer needs `-PpluginVersion=` overrides (it reads gradle.properties), and the VSCode workflow no longer rewrites package.json in the workspace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
versionpluginVersionBefore publishing, each workflow checks that the
vscode-v<version>/jetbrains-v<version>tag does not already exist locally or on origin, and fails fast with a clear message asking the maintainer to bump the manifest if it does. Gradle no longer needs-PpluginVersion=overrides (it reads gradle.properties), and the VSCode workflow no longer rewrites package.json in the workspace.Summary
Linked Issue
Closes #
Testing
pnpm lintpnpm buildpnpm testChecklist