Update to use JReleaser #157
Conversation
|
Fixes CXTOOLS-558 |
|
I can see that the GHA pipeline failed last time - do you know why it failed? |
zmarkan
left a comment
zmarkan
left a comment
There was a problem hiding this comment.
Left a couple of minor comments.
Also:
- I can see that the GHA pipeline failed last time it ran - Do you know why it failed?
- The commit history has a lot of "noise" in it - there are several commits with the same message "fix", and a commit that explicitly calls that a key was accidentally committed.
Please squash the commit history so that it looks cleaner.
|
|
||
| withXml { |
There was a problem hiding this comment.
Can you add some high level comments explaining what this block does? I understand it now that it deals with explicit dependency version pinning in the generated pom file but it's not going to be obvious when someone looks at this in a couple of months.
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: '18' | ||
| java-version: '17' |
There was a problem hiding this comment.
Genuine question: Why the java version downgrade here from 18 to 17? (I don't have an opinion about it)
There was a problem hiding this comment.
That was unintentional, Claude was insistent on changing it to 17 when we were debugging. It's back to 18 now
| JRELEASER_GPG_PASSPHRASE: ${{ secrets.ORG_GRADLE_PROJECT_GPG_SIGNING_IN_MEMORY_KEY_PWD }} | ||
| run: | | ||
| ./gradlew publish | ||
| ./gradlew :DittoToolsAndroid:jreleaserFullRelease -PLIBRARY_VERSION=${{ github.event.release.tag_name }} --stacktrace |
There was a problem hiding this comment.
Why do you need to run this with --stacktrace flag? I'd expect this to be removed once the pipeline is productionized.
There was a problem hiding this comment.
Was for debugging, removed it now that it's working.
acoyner
force-pushed
the
temp/jreleaser
branch
from
be67466 to
47979b0
Compare
acoyner
force-pushed
the
temp/jreleaser
branch
from
47979b0 to
f7aa2e6
Compare
|
I had been deleting the all the GHAs since they were for testing and forgot that one failed one. I just did another so the most recent attempt should show as successful now @zmarkan |
Published 4.0.3-TEST to Maven Central Repository: https://central.sonatype.com/publishing/deployments
And tested it out with a demo app to verify that everything works.