Skip to content

Conversation

@acoyner
Copy link
Contributor

@acoyner acoyner commented Oct 29, 2025

  • Replaced bottom bar with back and exit buttons in TopBar
  • Updated menu design to match DittoSwiftTools with sections (Network, System, Data & Debugging) and icons for all menu items
  • TopAppBar reads and matches the parent app's status bar color
  • Updated app/build.gradle to use local project module (project(':DittoToolsAndroid')) instead of published package for testing

Before:
Screenshot 2025-10-29 at 11 30 30 AM

After:
Screenshot 2025-10-29 at 11 40 08 AM

@acoyner acoyner requested a review from a team as a code owner October 29, 2025 16:06
@rajramsaroop
Copy link
Contributor

Have we tested this on an external app? Like the demo chat app or Pos/KDS app? It looks fine here just running the standalone app, but I'd like to see it in an integration

@acoyner
Copy link
Contributor Author

acoyner commented Oct 29, 2025

@rajramsaroop Here's what it looks like in the POS/KDS app: https://www.loom.com/share/e35ee5b1e3284b779153b913d3402d0e

Ideally you'd let the TopNavBar be the header, so it looks a little off in this case, but it still provides some useful nav

@rajramsaroop
Copy link
Contributor

@rajramsaroop Here's what it looks like in the POS/KDS app: https://www.loom.com/share/e35ee5b1e3284b779153b913d3402d0e

Ideally you'd let the TopNavBar be the header, so it looks a little off in this case, but it still provides some useful nav

thanks for doing this. i think it looks a little awkward just because of how the pos demo app implements tools. i think if it was an alert dialog/modal it would look a lot better (or something similar like a bottom sheet), but thats something a customer can easily implement

implementation(libs.androidx.lifecycle.runtime.compose)
implementation(platform(libs.androidx.compose.composeBom))
implementation(libs.androidx.compose.runtime.runtimeLivedata)
implementation(libs.androidx.compose.material.icons.extended)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a linear ticket to bundle the material icons with tools, as opposed to including the library?

Out of scope for this PR.

But including the material icons as a dependency increases apk size, since its including all icons (and variants). We should be mindful to not increase a customer's apk size if not needed.

I am not sure if gradle would be smart enough to not include these resources if not needed at compile time, that might be something, as part of the ticket you create, to see if the apk size is significantly reduced by removing this library/dependency and just including the icons we want

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, and I can test it out to see how much of a difference it makes

Copy link
Contributor

@rajramsaroop rajramsaroop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment regarding creating a Linear ticket, but doesn't need to be a blocker for approving, so I'm hitting approve 👍🏾

@acoyner acoyner merged commit 94ef205 into main Oct 31, 2025
@acoyner acoyner deleted the ac/update-menu-ui branch October 31, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants