Skip to content

Conversation

@ErikEverson
Copy link
Collaborator

  • Updated to 4.11 Ditto SDK
  • Fixed breaking change with optional value on execute

@ErikEverson ErikEverson self-assigned this Jul 2, 2025
@ErikEverson ErikEverson requested a review from Copilot July 2, 2025 19:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the Ditto SDK to version 4.11 and fixes a breaking change by defaulting the optional arguments parameter to an empty dictionary when calling execute.

  • Updated Ditto SDK to 4.11.
  • Default arguments to [:] to accommodate the SDK’s changed execute signature.
Comments suppressed due to low confidence (1)

Sources/DittoChatCore/Utilities/Publishers.swift:27

  • Add a unit test to verify the behavior when arguments is nil, ensuring the default empty dictionary path behaves as expected.
                    let result = try await self.execute(query: query, arguments: arguments ?? [:])

@ErikEverson ErikEverson merged commit 4e0d5ac into main Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants