Support renamed GETDNS_RCODE_BADCOOKIE#39
Merged
joelpurra merged 1 commit intogetdnsapi:developfrom Jun 9, 2021
Merged
Conversation
- Workaround for breaking change in upstream getdns versions after `getdns` v1.6.0; `GETDNS_RCODE_COOKIE` constant was renamed to `GETDNS_RCODE_BADCOOKIE`. - The renamed constant has not yet been included in an upstream `getdns` released, so this is a preemptive measure. Fixes getdnsapi#38. See - getdnsapi#38 - https://github.com/getdnsapi/getdns - getdnsapi/getdns#471 - getdnsapi/getdns@5c79e2c --- To test using latest `getdns` on Ubuntu 21.04. ```shell sudo apt install libunbound-dev libidn2-dev libssl-dev libevent-dev libuv1-dev libev-dev check git clone 'git@github.com:getdnsapi/getdns.git' cd getdns mkdir build cd build cmake .. make ``` Rebuild `getdns-node` targeting the newly built version (without installing it). ```shell LIBRARY_PATH="/the/path/to/your/getdns/build" CPLUS_INCLUDE_PATH="/the/path/to/your/getdns/build" npm run --silent rebuild ``` Current `getdns` commit on the `develop` branch is `291e0018817269b72c7cbd6c3e531acba95f563f`. - https://github.com/getdnsapi/getdns/tree/develop - getdnsapi/getdns@291e001
Collaborator
Author
|
Merged and released the fix as npm install getdns@latest |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getdnsv1.6.0;GETDNS_RCODE_COOKIEconstant was renamed toGETDNS_RCODE_BADCOOKIE.getdnsreleased, so this is a preemptive measure.Fixes #38.
See
To test using latest
getdnson Ubuntu 21.04.Rebuild
getdns-nodetargeting the newly built version (without installing it).Current
getdnscommit on thedevelopbranch is291e0018817269b72c7cbd6c3e531acba95f563f.