Skip to content

Conversation

@Shamim-97
Copy link
Contributor

@Shamim-97 Shamim-97 commented Nov 19, 2025

All Submissions:

  • My code follow the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included related pull request(s) (optional)
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

Related Pull Request(s)

  • Full PR Link

Closes

How to test the changes in this Pull Request:

  • Steps or issue link

Changelog entry

Title

Detailed Description of the pull request. What was previous behaviour
and what will be changed in this PR.

Before Changes

Describe the issue before changes with screenshots(s).

After Changes

Describe the issue after changes with screenshot(s).

Feature Video (optional)

Link of detailed video if this PR is for a feature.

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 19, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch Appearance_tab_e2e_test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Shamim-97 Shamim-97 self-assigned this Nov 19, 2025
@Shamim-97 Shamim-97 merged commit 88d5bf6 into enhance/new-admin-settings-fixing-and-e2e-testing Dec 17, 2025
1 check passed
@Shamim-97 Shamim-97 deleted the Appearance_tab_e2e_test branch December 17, 2025 03:39
akzmoudud added a commit that referenced this pull request Dec 18, 2025
#2927)

* set ids

* test case

* e2e testing for newGeneralMarketplace

* e2e testing for vendor onboarding section

* Construct mapping new social onboarding page with old setting page and fixing this page bugs

* fix bugs and enhancement of vendor - vendor capabilities page

* e2e test for vendor capabilities page

* admin settings: Data driven test

* Re-organized the test cases and fix the menu DOM id duplication

* update: general settings

* Add aria label for radio

* Add e2e tests for new General

> marketplace settings

* fix: e2e admin page inheritance

* e2e: Update test steps

* feat: Add checkbox field type support for toggle switches in admin settings tests

- Add new 'checkbox' field type to adminSettingsPageNew.ts to handle DOM elements with 'enabled' class
- Update selector logic to click on visible label while checking state from hidden input element
- Add Enable Single Seller Mode field to old dataset in generalMarketplace.spec.ts
- Update test values and selectors for marketplace settings synchronization testing
- Add debug logging for checkbox state verification

* Updated radio type for handling old and new radio buttons

* debug: Add console logging for checkbox state verification in admin settings tests

* fix: resolve E2E test timeout errors in General settings migration test

- Fix async iteration by replacing forEach with for...of loop to properly await operations
- Increase element visibility timeout from 10s to 15s for old admin page
- Add explicit wait for element attachment before scrolling
- Improve page stabilization with longer waits for old admin interface
- Add conditional navigation check to prevent unnecessary operations

Resolves timeout errors:
- TimeoutError on #dokan_settings_general selector
- Test ended error due to unwaited async operations

* feat: add reloadUrl method and optimize E2E test performance

- Add reloadUrl method to AdminSettingsPageNew for forced page reload
- Fix missing await statements in updateSettings method
- Remove unnecessary waitForTimeout calls to improve test speed
- Restructure General settings migration test with two separate tests:
  * Test 1: New settings to old settings synchronization
  * Test 2: Old settings to new settings synchronization
- Optimize element visibility checks and navigation timing

This improves test reliability and reduces overall test execution time.

* Rename the steps

* e2e test for generalMarketplace page

* Vendor Onboarding Page

* pages of vendor section

* Set ID of showHide fields

* test: add E2E testcases for General pages

* Social Onboarding Page

* improvement

* test: add E2E testcases for General pages

* Delete tests/pw/tests/e2e/productAdvertisement.spec.ts

* Vendor Capabilities Page

* Vendor Subscription Page

* Single Product Milti-vendor Page

* Moderation RMA Page

* Updated VendorSubscription Page

* Moderation pages templets

* Moderation Store Support Page

* Moderation Live Chat Page

* Moderation Abuse Report Page

* Implement mapping of delivery time page between new and old page

* Implement mapping of new shipment settings page with old setting page

* Shipment settings Page

* Shipment Delivery Time Page

* Updated Shipment Settings Page

* Implement proper option filed of Privacy Policy Page (Compliance -> Privacy )

* Complaince Privacy Page

* Compliance EU Complaince Page

* Fix keys of Shipping Fee, Product Tax Fee and Shipping Tax Fee from vendor to seller as old page

* Transaction Fees Page

* Fixed Commission Page Mapping

* Transaction Commission Page

* Transaction reverse Withdrawal

* Implement mapping of Minimum Withdraw Limit and Withdraw Threshold of transaction withdraw page

* Transaction Withdraw Page

* updated e2e test for Available Vendor Section Display Position field ( Vendor SPMV )

* Fix component for tooltip

* fix mb

* updated

* Testing (fix mapping)

* Make code workable for callback functions and map customer details visibility

* Callback function for COD Payments

* Fix (add_tooptip) function for text type field

* Make dokanFieldLabel component ready for haldeling tooltip using our DokanTooltip component

* Make tooltip message correct(helper_text to tooltip) of dokan component (DokanFieldLabel and DokanSwitch)

* Give and fix tooltip message of Vendor Onboarding page

* Fix 'textarea' field tooltip section

* Fixed 'copy' component tooltip section

* fix 'showhide' component tooltip section

* updated

* Implement settings for keeping existing data with updated data

* Implement Callback Functions for Moderation -> Abuse and RMA reasons field

* Implement callback function for Welcome Wizard field

* Implement callback function for Eendor Extra Fields

* Implement callback function for Customer Extra Fields

* Implement callback function for Delivery support

* Implement Callback Function for Penalty Actions After Grace Period filed and fix option names

* new-admin-settings-printful-ai-wholesale-page-e2e-testing (#2973)

* in progress

* Ai Content generation page e2e

* Add SMS gateway  and Email vendor verification settings mapper (#2977)

* e2e test for generalMarketplace page

* Vendor Onboarding Page

* pages of vendor section

* Set ID of showHide fields

* Social Onboarding Page

* Vendor Capabilities Page

* Vendor Subscription Page

* Single Product Milti-vendor Page

* Moderation RMA Page

* Updated VendorSubscription Page

* Moderation pages templets

* Moderation Store Support Page

* Moderation Live Chat Page

* Moderation Abuse Report Page

* Implement mapping of delivery time page between new and old page

* Implement mapping of new shipment settings page with old setting page

* Shipment settings Page

* Add SMS gateway  and Email vendor verification settings mapper

* Update mapper for change Ui design

---------

Co-authored-by: Moudud Ahmed <abdulkader225704@gmail.com>
Co-authored-by: Kamruzzaman <kzamanbn@gmail.com>

* Implement callback function for Discount Editing field

* Implement callback function for Shipment Status field

* Set tooltips of filelds of vendor capabilities and vendor subscription page

* Set comission page Heading description and tooltips of this page fields

* Complete Quote Settings and Product Advertisement Settings test (#2972)

* Vendor verification email sms page e2e test (#2982)

* Add SMS gateway  and Email vendor verification settings mapper

* EmailAndSmsGatewayPagee2eTest

* Appearance tab e2e test (#2995)

* Add SMS gateway  and Email vendor verification settings mapper

* EmailAndSmsGatewayPagee2eTest

* e2etesting  in progress

* appearance_tab_e2e_test

* Vendor verification e2e test (#2998)

* Vendor verification page e2e test

* Vendor Verification page e2e test

* Appearance > Color Customizer mapper (#2999)

* Verification Sms Gateways Page Redegin (#3021)

* feat: add single product preview settings mapper with legacy compatibility (#3034)

* Add tooltip in new admin settings and redesign (#3036)

* Doc link update (#3001)

* Appearance > Color Customizer mapper

* New ui doc link updated  In Ai Assist page

* fix curly brace

* fix store Page Store Header Template (#3037)

* fix e2e for field 'Show Customer info'

* fix e2e for field 'welcome wizard' (Inverted value)

* remove subscription cancel and alert email locators from e2e

---------

Co-authored-by: Md Mahbub Rabbani <mahbub.rucse@gmail.com>
Co-authored-by: SHAMIM <111671483+Shamim-97@users.noreply.github.com>
Co-authored-by: Kamruzzaman <kzamanbn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants