Conversation
Fixes CI failure where pnpm/action-setup couldn't determine which pnpm version to install. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Provenance verification requires repository.url in package.json to match the GitHub source. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the package.json file by adding the packageManager field and repository-related metadata. The review feedback identifies a likely typo in the specified pnpm version that could cause environment preparation failures and suggests using shorthand syntax for the repository field to reduce redundancy and simplify the configuration.
| { | ||
| "name": "@formo/cli", | ||
| "version": "0.2.0", | ||
| "packageManager": "pnpm@10.28.2", |
There was a problem hiding this comment.
The version 10.28.2 for pnpm appears to be a typo. pnpm 10 is a very recent major version and likely has not reached such a high patch number yet. An invalid version in the packageManager field will cause corepack to fail when attempting to prepare the environment. Please verify the intended version (e.g., 9.15.4 or 10.0.0).
| "packageManager": "pnpm@10.28.2", | |
| "packageManager": "pnpm@10.0.0", |
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/getformo/cli.git" | ||
| }, | ||
| "homepage": "https://github.com/getformo/cli#readme", | ||
| "bugs": { | ||
| "url": "https://github.com/getformo/cli/issues" | ||
| }, |
There was a problem hiding this comment.
For GitHub-hosted repositories, you can simplify the repository field using the shorthand syntax. Additionally, since the homepage and bugs URLs follow the standard GitHub pattern, they can be automatically inferred by npm, allowing you to remove these redundant fields and keep the package.json cleaner.
"repository": "getformo/cli",
1 participant
No description provided.