1.0.2#10
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e25779be8f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Get the previous version tag (second most recent v* tag by version order) | ||
| # This is more reliable than using git describe which follows commit ancestry | ||
| CURRENT_TAG=${{ github.ref_name }} | ||
| PREV_TAG=$(git tag -l 'v*' --sort=-version:refname | grep -v "^${CURRENT_TAG}$" | head -1) |
There was a problem hiding this comment.
Select previous release tag from commit ancestry
Using git tag -l 'v*' --sort=-version:refname | ... | head -1 picks the highest-version non-current tag globally, not the nearest tag reachable from the release commit, so changelog generation can break when releasing an older hotfix tag while a newer major tag already exists. In that case PREV_TAG can become a descendant/unrelated tag (for example v2.0.0 when publishing v1.0.2), and git log ${PREV_TAG}..HEAD may produce an empty or incorrect commit list, resulting in misleading release notes.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Code Review
This pull request increments the package version from 1.0.1 to 1.0.2 in both package.json and package-lock.json. Additionally, it updates package.json to include repository metadata and publishing configurations for public access and provenance. I have no feedback to provide.
Uh oh!
There was an error while loading. Please reload this page.