Skip to content

Clean up dependencies#11

Merged
yosriady merged 1 commit into
mainfrom
chore/deps
Mar 27, 2026
Merged

Clean up dependencies#11
yosriady merged 1 commit into
mainfrom
chore/deps

Conversation

@yosriady
Copy link
Copy Markdown
Collaborator

@yosriady yosriady commented Mar 27, 2026

@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedjest@​29.7.0 ⏵ 30.3.0100 +110070 +294100
Updated@​types/​jest@​29.5.14 ⏵ 30.0.01001007781100
Updated@​types/​node@​25.0.3 ⏵ 25.5.0100 +110081 +195100
Updated@​swc/​core@​1.15.7 ⏵ 1.15.219210010096 +2100

View full report

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates Jest and its associated type definitions to version 30, while also replacing the dependency overrides for minimatch and picomatch with test-exclude and brace-expansion. A suggestion was made to pin the versions of these new overrides to improve dependency stability.

Comment thread package.json
Comment on lines +39 to +40
"test-exclude": "^8.0.0",
"brace-expansion": "^5.0.5"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better dependency stability and to prevent unexpected updates, it's a good practice to pin the versions in the overrides section. This ensures that npm install will always use the exact specified version, avoiding potential issues from automatic minor or patch updates.

I suggest pinning test-exclude to 8.0.0 and brace-expansion to 5.0.5.

Suggested change
"test-exclude": "^8.0.0",
"brace-expansion": "^5.0.5"
"test-exclude": "8.0.0",
"brace-expansion": "5.0.5"

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@yosriady yosriady merged commit 1864d2a into main Mar 27, 2026
5 checks passed
@yosriady yosriady deleted the chore/deps branch March 27, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant