Skip to content

Increase min release age to 48h#14

Merged
yosriady merged 1 commit into
mainfrom
chore/npm-sec
May 12, 2026
Merged

Increase min release age to 48h#14
yosriady merged 1 commit into
mainfrom
chore/npm-sec

Conversation

@yosriady
Copy link
Copy Markdown
Collaborator

@yosriady yosriady commented May 12, 2026


View in Codesmith
Need help on this PR? Tag @codesmith with what you need.

  • Let Codesmith autofix CI failures and bot reviews

@yosriady yosriady merged commit 475d45a into main May 12, 2026
8 checks passed
@yosriady yosriady deleted the chore/npm-sec branch May 12, 2026 07:38
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a .npmrc file with a min-release-age configuration. Feedback was provided regarding the use of a non-standard npm configuration key, a potential discrepancy between the value and the intended duration, and a missing trailing newline.

Comment thread .npmrc
@@ -0,0 +1 @@
min-release-age=2 No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The configuration key min-release-age is not a standard npm configuration option and will be ignored by the npm CLI. If this is intended for a security tool, please ensure it is placed in the correct configuration file. Additionally, there is a potential discrepancy between the PR title ('48h') and the value (2); if the tool expects hours, this should be updated to 48. Finally, the file is missing a trailing newline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant