chore(CI): prevent tag-name command injection in release workflow#15
Merged
Conversation
The publish job runs with id-token:write (npm OIDC trusted publishing)
and contents:write, and interpolated the attacker-influenceable tag
name (github.ref_name and tag-derived step outputs) directly into run:
scripts. Git ref names permit shell metacharacters, so a tag like
v1.0.0$(...) could execute arbitrary commands with publish privileges.
- Move all tag-derived values to env: blocks, referenced as quoted
shell variables instead of ${{ }} interpolation in run: bodies
- Add strict semver tag validation that fails the workflow before any
untrusted value is used
- Pin actions/checkout and actions/setup-node to commit SHAs and npm
to an exact version (immutable, retains OIDC trusted publishing)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Revert the npm version pin from a50d49a back to npm@latest. The command-injection fix and action SHA-pins are retained; npm itself is a first-party tool and npm@latest auto-receives npm's own security patches, which was the preferred tradeoff here. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Adds the .deepsec/ workspace (config + project context) so teammates inherit the threat model and scan setup. node_modules/, .env.local, and generated scan output (files/, runs/, reports/, project.json) remain gitignored. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need help on this PR? Tag
@codesmithwith what you need.