Skip to content

P-2208: Harden github actions #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yosriady merged 1 commit into from
May 21, 2026
Merged

P-2208: Harden github actions #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
version: 2
updates:
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "weekly"
commit-message:
prefix: "ci"
labels:
- "dependencies"
- "github-actions"
cooldown:
default-days: 7
Comment on lines +12 to +13
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The cooldown property is not a supported configuration option for GitHub Dependabot. Including unknown keys in dependabot.yml may cause the configuration to be flagged as invalid or ignored in the repository's 'Dependency graph' settings. If the intention is to throttle updates or reduce noise, consider using the groups feature to bundle updates or adjusting the schedule.interval.


- package-ecosystem: "npm"
directory: "/"
schedule:
interval: "weekly"
commit-message:
prefix: "deps"
labels:
- "dependencies"
open-pull-requests-limit: 10
cooldown:
default-days: 7
Comment on lines +24 to +25
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The cooldown property is not recognized by GitHub Dependabot. While pnpm 11 supports minimumReleaseAge in pnpm-workspace.yaml (which is correctly configured in this repository), Dependabot does not have a corresponding configuration key. This block should be removed to ensure the configuration adheres to the official schema and functions as expected.

6 changes: 6 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false

- name: Setup pnpm
uses: pnpm/action-setup@0e279bb959325dab635dd2c09392533439d90093 # v6.0.8
Expand All @@ -42,6 +44,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false

- name: Setup pnpm
uses: pnpm/action-setup@0e279bb959325dab635dd2c09392533439d90093 # v6.0.8
Expand All @@ -65,6 +69,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false

- name: Setup pnpm
uses: pnpm/action-setup@0e279bb959325dab635dd2c09392533439d90093 # v6.0.8
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ jobs:
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 0 # Fetch all history for changelog generation
persist-credentials: false

- name: Verify tag is on main branch
env:
Expand All @@ -42,7 +43,6 @@ jobs:
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: "22.14.0"
cache: 'pnpm'

# Trusted publishing (OIDC) is an npm-registry feature; keep the
# publish step on the npm CLI even though deps use pnpm.
Expand Down Expand Up @@ -114,7 +114,7 @@ jobs:
echo "Generating changelog from $PREV_TAG to $GITHUB_REF_NAME"
# Extract commits with PR numbers and format them
# Use tab as delimiter to safely handle semicolons and special characters
COMMITS=$(git log ${PREV_TAG}..HEAD --pretty=format:"%s %h" --no-merges)
COMMITS=$(git log "${PREV_TAG}..HEAD" --pretty=format:"%s %h" --no-merges)
else
echo "No previous tag found, using all commits"
COMMITS=$(git log --pretty=format:"%s %h" --no-merges)
Expand Down