P-2208: Harden github actions#32
Conversation
- dependabot: 7-day cooldown on github-actions + npm ecosystems - ci.yml: persist-credentials: false on all 4 checkouts; explicit pnpm version: 11 - release.yml: persist-credentials: false; drop pnpm cache from setup-node (cache-poisoning mitigation); quote variable to fix SC2086; explicit pnpm version: 11 Refs P-2208. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request attempts to introduce a cooldown property to the Dependabot configuration for both GitHub Actions and npm ecosystems. However, the review feedback correctly identifies that cooldown is not a supported key in the official Dependabot schema, which will lead to validation errors and prevent Dependabot from processing updates for these ecosystems.
| cooldown: | ||
| default-days: 7 |
There was a problem hiding this comment.
The cooldown property is not a supported configuration key in the official GitHub Dependabot schema. Including this key will cause a validation error, and Dependabot will fail to process updates for the github-actions ecosystem. If the intention is to delay updates to mitigate potential supply chain risks (e.g., waiting for a 'soak' period), Dependabot does not currently support this natively. You may need to use a third-party tool or adjust the schedule to achieve a similar effect.
| cooldown: | ||
| default-days: 7 |
There was a problem hiding this comment.
The cooldown property is not recognized by the Dependabot configuration parser. This will likely result in a 'Dependabot couldn't parse your .github/dependabot.yml' error in the GitHub repository settings, preventing updates for the npm ecosystem. It is recommended to remove these lines to ensure the configuration remains valid.
The `with: version: 11` on `pnpm/action-setup` conflicts with `packageManager: pnpm@11.1.1` in package.json — the action refuses both and errors with ERR_PNPM_BAD_PM_VERSION. Drop the action input and let action-setup resolve from packageManager, which is the more precise pin. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This is incorrect —
|
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Done in e539803, but flagging for posterity: the Removing it anyway for consistency with sibling SDKs ( |
Refs P-2208.
Need help on this PR? Tag
@codesmithwith what you need.