Merged
Conversation
yosriady
requested changes
Oct 14, 2024
yosriady
reviewed
Oct 15, 2024
yosriady
requested changes
Oct 16, 2024
khanhngn-dev
previously requested changes
Oct 16, 2024
yosriady
approved these changes
Oct 17, 2024
yosriady
reviewed
Oct 17, 2024
src/FormoAnalytics.ts
Outdated
|
|
||
| // Function to send tracking data | ||
| private async trackEvent(action: string, payload: any) { | ||
| private async trackEvent(action: string, payload: any, retries: number = 3) { |
Contributor
There was a problem hiding this comment.
I think this should be hardcoded as a constant to prevent spam and abuse (a builder can set a really high retry number and spam the endpoint)
Contributor
There was a problem hiding this comment.
@kiuthy229 Remove the retries input and hardcode it with a constant
Contributor
Author
|
|
yosriady
requested changes
Oct 17, 2024
src/FormoAnalytics.ts
Outdated
|
|
||
| // Function to send tracking data | ||
| private async trackEvent(action: string, payload: any) { | ||
| private async trackEvent(action: string, payload: any, retries: number = 3) { |
Contributor
There was a problem hiding this comment.
@kiuthy229 Remove the retries input and hardcode it with a constant
Contributor
|
Running into a network error / Axios error when I paste the snippet from https://www.npmjs.com/package/@formo/analytics 
I remove the snippet from the of formo.so - Feel free to re-test when you're free
|
yosriady
approved these changes
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.