Upgrade to pnpm 11#253
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the min-release-age configuration in the .npmrc file. A review comment identifies that the value is interpreted in minutes, meaning the change to 2 reduces the threshold to two minutes rather than two days; a correction to 2880 was suggested to maintain the previous 48-hour duration.
| auto-install-peers=false | ||
| block-exotic-subdeps=true | ||
| min-release-age=48h | ||
| min-release-age=2 |
There was a problem hiding this comment.
The min-release-age configuration in pnpm is measured in minutes. Changing this value to 2 sets the threshold to only 2 minutes, which is likely not the intended duration if you were aiming for 2 days (48 hours). To maintain a 48-hour window, the value should be 2880.
min-release-age=2880
yosriady
force-pushed
the
chore/release-age
branch
from
e1f22bb to
ab679f4
Compare
yosriady
force-pushed
the
chore/release-age
branch
from
ab679f4 to
5d28c09
Compare
Contributor
Author
|
TODO: update lockfile by running pnpm 11 locally after 48 hours min release age |
- Ignore .claude/ (local Claude Code settings + worktrees) so the nested repo copies are never committed. - Remove minReleaseAge: 2 from pnpm-workspace.yaml — not a valid pnpm key (silently ignored, leftover from old .npmrc). The active supply-chain cooldown remains minimumReleaseAge: 2880 (48h). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Dependabot could not auto-fix these (transitive dev deps with no parent release bumping them), so pin via pnpm overrides — same pattern already used for picomatch/diff/hono: - serialize-javascript >=7.0.5 (was 6.0.2 via mocha): fixes RCE via RegExp.flags/Date.toISOString (#75) and CPU-exhaustion DoS (#103) - fast-uri >=3.1.2 (was 3.1.0 via webpack/ts-loader): fixes path traversal (#104) and host confusion (#105) Dev/build-only — not shipped in @formo/analytics. Full mocha suite passes (594/594) with the serialize-javascript 6->7 major bump. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need help on this PR? Tag
@codesmithwith what you need.