This repository was archived by the owner on Dec 8, 2023. It is now read-only.
feat: add thousands separator#18
Merged
morgante merged 5 commits intogetgrit:mainfrom Sep 23, 2023
vlopezferrando:thousands-separator
Merged
feat: add thousands separator#18morgante merged 5 commits intogetgrit:mainfrom vlopezferrando:thousands-separator
morgante merged 5 commits intogetgrit:mainfrom
vlopezferrando:thousands-separator
Conversation
morgante
approved these changes
Sep 18, 2023
Contributor
morgante
left a comment
There was a problem hiding this comment.
I'm pretty sure we could do this generically without recursion, using either a more complex regex or a split of some sort.
morgante
suggested changes
Sep 19, 2023
Comment on lines
+12
to
+13
| `$number` where { | ||
| $number <: or { integer(), float() }, |
Contributor
There was a problem hiding this comment.
This is another example of the anti-pattern (maybe we should put this in the docs). If a variable is immediately restricted after assignment, start with the restriction.
Suggested change
| `$number` where { | |
| $number <: or { integer(), float() }, | |
| or { integer(), float() } as number where { |
Contributor
Author
|
Would it be better if the pattern just added one underscore? Then, if applied multiple times, it would yield the right output no matter how long the number is. |
morgante
approved these changes
Sep 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add thousands separator (
1_000_000) to numbers (ints and floats, positive or negative).Limitations: