This repository was archived by the owner on Dec 8, 2023. It is now read-only.
fix: multiple imports with ensure_included()#25
Merged
morgante merged 2 commits intogetgrit:mainfrom Sep 19, 2023
vlopezferrando:ensure-imported-many-times
Merged
fix: multiple imports with ensure_included()#25morgante merged 2 commits intogetgrit:mainfrom vlopezferrando:ensure-imported-many-times
ensure_included()#25morgante merged 2 commits intogetgrit:mainfrom
vlopezferrando:ensure-imported-many-times
Conversation
vlopezferrando
changed the title
$name is not already on $GLOBAL_BARE_IMPORTS before appending
vlopezferrando
changed the title
$name is not already on $GLOBAL_BARE_IMPORTS before appendingensure_included()
morgante
approved these changes
Sep 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24
Also, I have observed that
ensure_included()doesn't match when there are other top-level imports (see this studio as an example).However, there is one issue still pending: if there is an import like
from math import log, and then you ensure the import ofmath, the pattern does not match. This has been reported as a separate issue: #26.